Skip to content

fix: wait for room list to be loaded before fetching pack info#1119

Merged
7w1 merged 1 commit into
SableClient:devfrom
mortebrume:push-vsxkqtrukqrx
Jul 18, 2026
Merged

fix: wait for room list to be loaded before fetching pack info#1119
7w1 merged 1 commit into
SableClient:devfrom
mortebrume:push-vsxkqtrukqrx

Conversation

@mortebrume

Copy link
Copy Markdown
Contributor

Description

Fixes a regression in #1112 where every subspace of a space with an emoji pack was shown separately in the server list with sliding sync. We now wait until the room list is loaded before fetching an emoji pack.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@mortebrume
mortebrume requested review from 7w1 and hazre as code owners July 18, 2026 22:40
@7w1
7w1 added this pull request to the merge queue Jul 18, 2026
Merged via the queue into SableClient:dev with commit 1acd39e Jul 18, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants