Repository navigation
Game: autopilot shifts a manual car; C is the car's view while playing; settings given twice are errors - #77
Merged
Merged
Conversation
…le playing; settings given twice are mistakes A manual car handed to the autopilot stayed in the gear it was in, as the autopilot never asks for a change: its driver now has the automatic gearbox while it drives, and the player's own back when they take over. In the native viewer C was both the car's next view and the next weather, and T moved the clock: while someone is played, and not flying, those keys are the game's. A .vehicle file took a second mass, gears or front spring=, and the last silently won; a .track file took a second name, or l= twice on a point. Each is now an error naming the line the first was on. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From review: with no track it took a manual car's gearbox and gave it back only on a second press, while driving nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Loose ends from earlier reviews of vehicles and circuits (#64), from a maintenance pass over the engine.
vehicle PATH manualnever changed gear when handed to the autopilot, because the autopilot never asks for a shift. While the car drives itself its driver now has the automatic gearbox. The player gets their own gearbox back when they take over, in whatever gear the car is in. Without a circuit the key does nothing, as before.cameraaction and the viewer's next-weather key, and T moved the clock. While someone is played and not flying, those keys are now the game's. They are the viewer's again while flying (V). The page has no such keys..vehiclefile took a secondmass,gearsorfront spring=, and the last one silently won. A.trackfile took a secondname, orl=twice on one point. Each is now an error that names the line the first was on. A setting may still be split across lines, asVehicleSpec::to_textwritesfront, as long as no key is given twice.docs/gameplay.md.Verified
a_manual_car_driving_itself_changes_gear_and_the_player_gets_their_gearbox_back. It fails without the fix (mutation-checked).spec.rsandtrack.rscover each repeat.gt.vehicleand theto_textround trip still parse.cargo test --workspace --releasepasses. fmt and clippy (-D warnings) are clean natively and for both wasm32 builds.Measured in Chrome on the RTX 5080
Main (8731867) against this pass's three branches merged together (#77, #78, #79), on the same scene files, each config run back to back. GPU time is the sum of every pass's timestamps per frame (a profiler injected into the page adds
timestampWritesto each pass), averaged over 250 to 500 frames after streaming settles. Fixed view:?time=12:00&day-length=0&weather=fair, default camera.?limits=webgpu?limits=webgpu?limits=webgpu--no-taa. Every after-vs-main PSNR falls inside main's own run-to-run spread, for example Temple 54–58 dB against 55.5–56.7 dB, and Cove storm 60.6–61.1 dB against 60.4 dB.screen gisplits into integrate 1.04 ms (its occlusion search is 0.27 ms of that), reflections 0.67 ms and trace 0.55 ms.Authorship
Written by: Claude Opus 5.5 through Claude Code
Reviewed by: Claude Sonnet 5.5. Approved with no correctness bugs. It checked:
resetand falling (put_backnever touches the driver);change_gearis sane when switched on mid-drive (in neutral or a stale reverse);to_textline round-trips and the error line numbers are right;Fixed from its points:
Noted, not changed:
C and T are the game's for a walker too, not only a car, which is what "while someone is played" means.
All code, text and comments in this pull request were written by a frontier AI model, with no human-written code, and will be reviewed by a frontier AI model before merging, as the Code of Conduct requires.
🤖 Generated with Claude Code