feat(pitr): add command to restore a database to a specific point in time - #1244
Draft
matthieu526-scalingo wants to merge 3 commits into
Draft
feat(pitr): add command to restore a database to a specific point in time#1244matthieu526-scalingo wants to merge 3 commits into
matthieu526-scalingo wants to merge 3 commits into
Conversation
matthieu526-scalingo
requested review from
SCedricThomas,
briceamen and
curzolapierre
and removed request for
a team and
briceamen
August 5, 2026 14:09
matthieu526-scalingo
marked this pull request as draft
August 5, 2026 14:10
curzolapierre
left a comment
curzolapierre
left a comment
Member
There was a problem hiding this comment.
Just a question otherwise LGTM
| return errors.Wrapf(ctx, err, "get Scalingo client") | ||
| } | ||
|
|
||
| operationID, err := c.DatabasePITRRestore(ctx, currentResource, addonName, restoreTime) |
Member
There was a problem hiding this comment.
Suggestion: what about adding a confirmation message to the end user?
Which would format the date as human readable (maybe add the local time conversion).
Member
There was a problem hiding this comment.
Praise thanks for this update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new command to restore PITR.
It reuses the same mechanism as maintenance. Both components are shared between SR addons and DR databases.
It adds a small check to ensure the time is correctly parsed.