use wasm rulesengine - #165
Merged
cbrady merged 2 commits intoAug 13, 2026
Merged
Conversation
bpapillon
previously approved these changes
Jul 16, 2026
bpapillon
left a comment
bpapillon
left a comment
Collaborator
There was a problem hiding this comment.
Nice.
A few things that could be followups:
- I'm a little anxious in general about packaging and install concerns related to the wasm binary - given this is kind of a non-standard thing to do, it seems like there are a lot of places along the chain of development -> end user install (bundling, publishing from nuget, downloading from nuget, installing) for the wasm binary to disappear or fail to load, and this seems like the kind of failure mode that might manifest in different ways across language and packaging ecosystems, while also being hard to catch pre-merge (since packaging hasn't happened yet). The E2E tests migt be the right place to catch this - perhaps we can follow up by making sure we have E2E tests that will fully exercise at least one flag evaluation that runs through the wasm binary on a library version that was installed from the package manager? This may already be the case, but regardless, could you check on the E2E tests after this to confirm this. Lmk if this doesn't make sense we can talk about it live.
- I was looking at GetVersionKey() - I'm not sure we actually use it in the cache-key as noted
bpapillon
previously approved these changes
Aug 10, 2026
cbrady
force-pushed
the
chris/schy-473-migrate-schematic-csharp-to-use-the-wasm-rules-engine
branch
from
August 11, 2026 14:18
ec968c7 to
039a3f5
Compare
bpapillon
approved these changes
Aug 13, 2026
cbrady
deleted the
chris/schy-473-migrate-schematic-csharp-to-use-the-wasm-rules-engine
branch
August 13, 2026 17:52
cbrady
pushed a commit
that referenced
this pull request
Aug 19, 2026
* [fern-generated] Update SDK Generated by Fern CLI Version: unknown Generators: - fernapi/fern-csharp-sdk: 2.71.1 * [fern-replay] Applied customizations Patches absorbed by generator (1): - patch-b8fc417e: use wasm rulesengine (#165) The generator now produces these customizations natively. --------- Co-authored-by: fern-api[bot] <115122769+fern-api[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.