Skip to content

Add checks about Kokkos options - #309

Open
tpadioleau wants to merge 1 commit into
SciCompMod:mainfrom
tpadioleau:add-compilation-guards
Open

Add checks about Kokkos options#309
tpadioleau wants to merge 1 commit into
SciCompMod:mainfrom
tpadioleau:add-compilation-guards

Conversation

@tpadioleau

@tpadioleau tpadioleau commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

This PR comes from errors in the Spack package. Kokkos provides cmake functions to help checking that options are enabled. As we require some kind of "exotic" Kokkos options, I think we should check they are actually enabled.

We were appending twice to CMAKE_MODULE_PATH, I removed one of them.

Note I also did that in https://github.com/CExA-project/ddc.

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@tpadioleau
tpadioleau force-pushed the add-compilation-guards branch from 472eb63 to a3008f2 Compare July 30, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant