Repository navigation
Read Elixir 1.20's test summary in the flake hunt - #96
Merged
Merged
Conversation
The first weekly hunt measured the floor and pinned legs (40 runs, 0 failures) but counted every run on the head and box legs as failed: Elixir 1.20 prints its summary as "Result: 798 passed (...)", and "Result: 797/798 passed" when a test fails, where 1.17 and 1.18 print "786 tests, 0 failures". The script found no summary in that form, and a run with no summary is counted as failed, so 40 green runs read red. - tools/flake_hunt.sh: the summary read accepts both forms. The verdict is still the exit code; the summary only shows the suite reported. - tools/probe_flake_hunt.sh: the fake mix speaks 1.20's form, green and red. Measured locally: the probe's two new cases fail before the change and pass after. On Elixir 1.20.4 the real suite with a planted failing test is named with its replay (exit 1), and two runs on a clean tree exit 0. Signed-off-by: Ayla Croft <aylacroft@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tooling only. Nothing a consumer of the package can hit changes.
Why. The first flake hunt measured the floor and pinned legs (40 runs, 0 failures) but counted every run on the head and box legs as failed. Elixir 1.20 prints its summary as
Result: 798 passed (11 properties, 787 tests), andResult: 797/798 passedwhen a test fails. Elixir 1.17 and 1.18 print786 tests, 0 failures. The script found no summary in the newer form, and it counts a run without a summary as failed, so 40 green runs read red. The guard did what it is for: it did not call an unmeasured run green.What changes
tools/flake_hunt.sh: the summary read accepts both forms. The verdict is still the exit code; the summary only shows that the suite reported.tools/probe_flake_hunt.sh: the fakemixspeaks Elixir 1.20's form, green and red.Evidence
Not yet measured