Repository navigation
Name an arm64 CPU in the ML-DSA-87 bench, and print no p99.9 it cannot resolve - #20
Merged
Merged
Conversation
…t resolve
The bench's first CI run on the box leg printed two things that were
not what they said:
- "machine: unknown (CPU part 0xd49)". arm64 Linux gives no model
name in /proc/cpuinfo, only the implementer and part numbers, and
the script fell back to "unknown". It now prints those numbers
("CPU implementer 0x41, CPU part 0xd49").
- At 500 rounds the p99.9 index is the last sample, so every p99.9
equalled max. A percentile is now printed only when a sample lies
above it, and "-" otherwise; the box leg runs 2,000 rounds per size,
the script's default, so its p99.9 is one.
No figure changes meaning, and nothing in lib/ changes.
Signed-off-by: Ayla Croft <aylacroft@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tooling and one CI argument. Nothing in
lib/or the Hex package changes.Why. The ML-DSA-87 bench's first CI run on the box leg printed two things that were not what they said:
machine: unknown (CPU part 0xd49). arm64 Linux gives no model name in/proc/cpuinfo, only the implementer and part numbers, and the script fell back to "unknown".What changes
tools/bench_mldsa.exs: with no model name, the label prints the implementer and part numbers (CPU implementer 0x41, CPU part 0xd49). A percentile is printed only when a sample lies above its index, and-otherwise.ci.yml: the box leg's bench runs 2,000 rounds per size (the script's default), so its p99.9 is a percentile.Evidence
CPU implementer 0x41, CPU part 0xd49; over this x86_64 machine, the model name as before.mix run tools/bench_mldsa.exs 500(OTP 28.5.0.8 over OpenSSL 3.5.9): every p99.9 prints-, exit 0. At 2,000 rounds every p99.9 lies below its max, exit 0.mix format --check-formatted,mix compile --warnings-as-errors,mix credo --strict: exit 0.Not yet measured