fix(code-index): end every seat wait through one authority - #2823
Merged
Merged
Conversation
|
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2405, #2365, #2550, #2612
Recovered from the audit-leftovers/scheduler-signals lane, which died in the 2026-10-01 restart; re-verified after rebasing on 134157d. The lane's #2209 (
MemoryRefusalRetryV1) item was not started and is not in this PR.Changes
open_with_policyis refused by a contended store lock now waits for the holder's release, a kernel lock wait on a dedicated thread raced against the reservation's cancellation, then reopens. Before, it surfaced as a failed mount.wait_for_code_generation_store_releasetakes the lock exclusively so a refused writer also outlasts readers.CodeIndexSeatWaitV1is seated / parked (CodeIndexSeatParkV1: worker park with remedy, unpublished, publication unreadable, seated-but-not-serving, unreachable readiness) / cancelled / deadline. The advisory runtime's separatewait_for_generation_changeloop and the compiler-diagnostics producer's own wait are deleted in favour of it. Seat parks map without a reason table.Evidence (rebased tree)
tracedecay-code-index-runtimelib 562 passed (1 ignored),tracedecay-code-index-retentionlib 114,tracedecaylib (advisory/deferred/activation selection) 35, fulldaemon_suite57 (all pass). New tests:a_first_mount_refused_by_a_held_store_lock_mounts_on_its_release,a_seat_wait_answers_a_parked_worker_with_its_park,a_readiness_wait_ends_when_the_registry_is_cancelled,owner_signals_wake_on_their_own_roots_publication,store_release_wait_outlasts_a_reader.CodeIndexSeatWaitV1doesn't exist.-D warnings(code-index-runtime, code-index-retention, tracedecay,--all-targets, test features),cargo fmt --all -- --check: clean. Windows cross-check: exit 0 (the oneBRANCH_TRACKING_FAILEDdead-code warning is pre-existing).