fix(plugin): repair validation gates on master - #3088
Open
devin-ai-integration[bot] wants to merge 28 commits into
Open
devin-ai-integration[bot] wants to merge 28 commits into
devin-ai-integration[bot] wants to merge 28 commits into
Conversation
The description for plugin/skills/investigating-unexpected-changes/SKILL.md used a single-quoted YAML scalar containing an unescaped apostrophe ('other agents' work'), so the Claude plugin validator's strict frontmatter parse failed on master. Double the quote per YAML single-quote escaping.
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Two repairs to plugin-validation.yml: (1) the manifest job pinned the repo's only setup-node v5.0.0, whose package-manager-cache default probes a pnpm executable before this job installs one, failing on master; pin the v7.0.0 SHA the sibling workflows use and disable the cache explicitly since the job only installs two npm packages. (2) The workflow previously ran only on push to master, so plugin breakage like the SKILL.md frontmatter error merged without gating; run the same paths filter on pull_request. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Contributor
Author
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
The retrieval SDK surface changed on master without regenerating plugin/chatgpt-extension/embedded/server.mjs, so every PR's Dashboard lane failed check:embedded with 'embedded/server.mjs is stale'. Rebuilt via pnpm run build. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
The churn-weighted hotspot rank used match on a boolean, which the workspace clippy lane rejects as clippy::match_bool. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Repository gates run cargo fmt --check; fold the long unwrap_or argument chain. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…ugin-validation-fix
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
# Conflicts: # .github/workflows/plugin-validation.yml # plugin/skills/investigating-unexpected-changes/SKILL.md
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…ugin-validation-fix
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…on-fix' into devin/1791146634-plugin-validation-fix Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> # Conflicts: # crates/tracedecay-code-index/tests/code_index_suite/production_orchestration.rs
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…on-fix' into repair/pr-3088-ci
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
master,20175c2e6dand977b08a14c:Claude native plugin validation,Manifest schema, and the Dashboard lane'scheck:embedded. It also fixes theclippy::match_boolerror introduced inhotspots.rsby those commits.pull_requesttrigger with the samepathsfilter toplugin-validation.yml, so plugin breakage is caught before merge instead of after it lands.Motivation
At
977b08a14c,masterfailsManifest schemaandClaude native plugin validationin run 37232169975. Every PR branched after that commit also fails theDashboardlane withembedded/server.mjs is stale, andClippybecausehotspots.rs:73triggersmatch_boolon a Boolean flag.The failures have four causes:
'appears inside a single-quoted YAML description ininvestigating-unexpected-changes/SKILL.md.package-manager-cachedefault insetup-node@v5.0.0probes forpnpmbeforepnpmexists.operations.tswithout rebuilding the committed ChatGPT extension bundle.hotspots.rsmatches on a Boolean flag.The plugin-validation workflow ran only after a push, so it did not block these changes before merge.
Changes
plugin/skills/investigating-unexpected-changes/SKILL.md: changesother agents' worktoother agents'' workto escape the YAML single quote..github/workflows/plugin-validation.yml: repinssetup-nodeto thev7.0.0SHA used bydistribution-acceptance.ymlandsdk-conformance.yml, setspackage-manager-cache: false, and applies the existingpathsfilter topull_request.plugin/chatgpt-extension/embedded/server.mjs: rebuilds the bundle withpnpm run buildfor the current SDK surface.crates/tracedecay-mcp/src/handlers/analysis/hotspots.rs: replaces thematchexpression,match churn_available, withif/elseto satisfy Clippy, then applies rustfmt.Test plan
pnpm run check:embeddedinplugin/chatgpt-extensionpasses (was stale before the rebuild)cargo clippy -p tracedecay-mcp --all-targets -- -D warningsclean; the other crates the master pushes touched (runtime-core,contracts,query,graph-query) also cleancargo fmt --all -- --checkcleancargo test -p tracedecay-mcp --lib hotspotspassesplugin/skills/*/SKILL.mdfrontmatter blocks parse as YAMLManifest schema+Claude native plugin validationalready green on this PR via the newpull_requesttrigger, the gate proves itselfChecklist
CHANGELOG.mdupdated (not updated; release-please generates it from commits).envfiles includedLink to Devin session: https://app.devin.ai/sessions/2b4ac3c29ab14ef5b7e024585b0f9187
Open in Devin Desktop: https://app.devin.ai/desktop/session/2b4ac3c29ab14ef5b7e024585b0f9187?variant=devin
Requested by: @ScriptedAlchemy
Link to Devin session: https://app.devin.ai/sessions/d1c43c1ea5264a0e9398d1b722b54447
Open in Devin Desktop: https://app.devin.ai/desktop/session/d1c43c1ea5264a0e9398d1b722b54447?variant=devin