fix(ci): repin sealed digests and fix clippy regressions - #3093
Open
devin-ai-integration[bot] wants to merge 6 commits into
Open
devin-ai-integration[bot] wants to merge 6 commits into
devin-ai-integration[bot] wants to merge 6 commits into
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PARTITIONED_FORMAT_STATE_DIGESTand threePARTITIONED_FORMAT_SEGMENTSentries to the bytes produced by the mergedmastercode (sha256:ab12b9ec…).redundant_guardsconditions incontext_scout/owner.rsinto their match patterns.&[target.clone()]probe slice in theedit_checktest withstd::slice::from_refto fixcloned_ref_to_slice_refs.Motivation
This is a follow-up to #3090. The context-tools and benchmark changes that merged with it (
536047b384,390cd90a89, anda60a1d3425) changed the canonical manifest and segment bytes. They also added code that triggersclippy::redundant_guardsandclippy::cloned_ref_to_slice_refs. As a result, thecore-storageandClippylanes are red onmaster.Format revision 21 does not change. The wire shape is unchanged, but the produced content changed, including the Java arity gating in
chunks.rs.Changes
crates/tracedecay-code-index/tests/code_index_suite/production_orchestration.rs: pins the new digest and updates three segment entries.crates/tracedecay-agent-hosts/src/agents/context_scout/owner.rs: moves outcome alternatives into match patterns.crates/tracedecay-mcp/src/handlers/edit_check.rs: usesstd::slice::from_reffor the borrowed probe slice.Test plan
cargo clippy --workspace --all-targets -- -D warningscleancargo fmt --all -- --checkcleanbash scripts/require-exact-test.sh cargo test -p tracedecay-code-index --test code_index_suite production_orchestration::partitioned_codec_has_stable_bytes_and_round_trips -- --exactpasses (was red on master)cargo test -p tracedecay-code-index --test code_index_suite, 205/205cargo test -p tracedecay-mcp --lib edit_check, 2/2node scripts/lint-commit-range.mjs --repository . origin/master HEADcleanChecklist
CHANGELOG.mdnot updated (test/lint repair only).envfiles includedLink to Devin session: https://app.devin.ai/sessions/1f0d1bf1427c4efcabbcdbd01e63cebc
Open in Devin Desktop: https://app.devin.ai/desktop/session/1f0d1bf1427c4efcabbcdbd01e63cebc?variant=devin
Requested by: @ScriptedAlchemy