Skip to content

Improve S3 Directory Listing - #973

Open
jfantinhardesty wants to merge 18 commits into
mainfrom
cleanup-performance-improvements
Open

jfantinhardesty wants to merge 18 commits into
mainfrom
cleanup-performance-improvements

Conversation

@jfantinhardesty

Copy link
Copy Markdown
Contributor

What type of Pull Request is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Describe your changes in brief

This PR introduces a new add-dir-markers CLI command to add directory markers to directories which currently don't have them. It also introduces a require-dir-markers S3 config option to improve directory listing performance by skipping the case to ListObjectsV2. This skips the known file extension work that had been done previously.

There is also an improvements to S3 RenameFile which now checks if the rename target is an existing directory and returns EISDIR.

Checklist

  • Tested locally
  • Added new dependencies
  • Updated documentation
  • Added tests

Related Issues

  • Related Issue #
  • Closes #

Comment thread cmd/add-dir-markers.go
Comment thread component/s3storage/client.go Outdated
Comment thread component/s3storage/client.go Outdated
Comment thread component/s3storage/config.go

This branch was successfully deployed

1 active deployment
testing — fdb03183 Deployed Oct 8, 2026 by jfantinhardesty via Cleanup Test Accounts (1.27, linux) #3831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants