Tileset with spacing causes size mismatch error

[bowlercaptain]

using a spritesheet with a single pixel of spacing, the inspector shows size mismatch errors. Instead, we should read the number of pixels from the tileset:

<tileset [...] spacing="1" [...]>

and use it to offset our pixel destinations by index * spacing and expect an additional final width/height of spacing * length in each dimension.

Error copy:

SuperTiled2Unity version: unknown, Unity version: 6000.1.14f1
Errors Detected. Your Tiled asset may not function correctly. Please follow directions to fix.
Mismatched Texture Sizes
Expected texture size: 203x186
Actual texture size: 256x128
Check import settings for 'tilemap.png'.
Max Size may be too small.

repro .tsx, which assumes it's in a single folder under assets (Assets/tiled, for example), and tilemap.png is in Assets/graphics/kenney_tiny-town/Tilemap/:

Kenney Tiny with spacing.txt

repro png (cc0)

I assume the new version of unity is not the cause of the problem, unless we're branching around this code with a whitelist instead of a blacklist for some reason.

[bowlercaptain]

Update: after vibing the "fix" for my problem, I realized that the sprite had been imported stretched and squashed. Switching Texture type to "Sprite" and back to "default" fixed it. Kind of mysterious, but perhaps we could trigger this fix ourselves if we notice that the file and the imported image mismatch?

[bowlercaptain]

So again, that PR does not fix this problem, the behavior I was attempting to add was already present, this just stashes all the relevant data in local variables to improve readability of the below code and tries to calculate for a new size mismatch error immediately. No pressure to merge, it's probably technically inferior for performance, and all we're doing is double-checking that our math here lines up with whatever was already true in the tiled export.

[Seanba]

Hi there, @bowlercaptain. I suspect what has happened is you've imported texture with the Default Texture Type and set the Non-Power of 2 to something like ToNearest. This is going to change the size of the imported texture on you (and Super Tiled2Unity, which is expecting a texture size that Tiled tells it about).

Is there a reason you are using the Default texture type? IMHO you should always use the Sprite type for tiles.