Harden security, recovery, and release assurance - #1
Open
AtHeartEngineer wants to merge 28 commits into
Open
Conversation
Phase 2 shipped durable runtime-state persistence, so several deferred notes are now resolved: S2 PoR round counter (cat::POR), own-card version floor (cat::CARD_VERSION), S4 envelope-digest gating (F1), and §14 split-state sealing are all live. W2-gc (old-epoch blob GC) stays open, now a disk-growth concern. Option B recorded as shipped in the ledger.
Collapse WHAT-narration and multi-line spec-clause comment essays to one-line WHY where non-obvious, delete the rest. Verified comment-only: stripping comments+blanks leaves byte-identical code. Per-crate tests, clippy (-D warnings), and fmt all green. por.rs's 64-line module block is now 18.
Compress multi-paragraph module docs and multi-line spec-clause/audit-narration comment blocks to one-line WHY where non-obvious, delete WHAT-narration; two misattached doc comments split back to their items. lib.rs 8579->7765, persist.rs 1808->1722, state.rs 266->242, tests ~-280. Verified comment-only: stripping comments+blanks leaves byte-identical code. Fixed a doc-lazy-continuation clippy error a compressed doc introduced (por_reboot_replay). Workspace clippy (-D warnings) and fmt clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the security-first remediation plan across durable state, recovery, restore, replica ingress, blob authorization, release assurance, the GUI, and test coverage. Adds fail-closed migration and key handling, bounded ceremony state, streaming restore, claimant recovery, structured diagnostics, independent vectors, fuzz targets, browser tests, and hardened CI and release workflows. Local formatting, strict Clippy, workspace tests, GUI tests, browser tests, fuzz smoke tests, CBOR vectors, policy gates, and native release builds passed before this pull request.