Skip to content

Bump tokio-rustls to 0.26.6 - #104

Open
rdettai-sk wants to merge 2 commits into
sekoiafrom
bump-tokio-rustls
Open

rdettai-sk wants to merge 2 commits into
sekoiafrom
bump-tokio-rustls

Conversation

@rdettai-sk

@rdettai-sk rdettai-sk commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Bumps tokio-rustls from 0.26.4 to 0.26.6 (lockfile only). The change that matters is tokio-rustls#198, released in 0.26.5: poll_read keeps decrypting records until hyper's buffer is full, instead of returning a single ≤16 KB record per poll. 0.26.6 fixes a 0.26.5 regression in which ConnectionAborted became a clean EOF.

How was this PR tested?

Test environment:

  • S3 connection task polls dropped from ~70k to ~7k/s per pod, and bytes per poll went from ~16 KB to ~190 KB.
  • Tokio time per downloaded MB did not change measurably (~2.2 ms/MB before and after). The per-byte cost is kernel receive work, not per-record userspace overhead.
  • Because polls are fewer and longer, the 16-256 ms tail of S3 task polls grew (0.15 → 2.5/s per pod), during a period when CFS throttling in the test environment also rose. Upstream draft tokio-rustls#209 caps the bytes read per poll to address this.

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings October 8, 2026 07:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.

@rdettai-sk

Copy link
Copy Markdown
Collaborator Author

The result of this bump is not conclusive. We should work on this upstream first (rustls/tokio-rustls#209)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants