Skip to content

Fix retention to use secondary - #108

Merged
rdettai-sk merged 1 commit into
sekoiafrom
fix-secondary-retention
Oct 12, 2026
Merged

rdettai-sk merged 1 commit into
sekoiafrom
fix-secondary-retention

Conversation

@rdettai-sk

Copy link
Copy Markdown
Collaborator

Description

Add an env variable to control if the retention is based on the primary or secondary QW_RETENTION_TIMESTAMP_MODE

  • primary: default, prune using primary
  • secondary-dry-run: still use primary but compared with secondary
  • secondary: prune using secondary

How was this PR tested?

Unit tests and will use dry run to double check

Copilot AI balanced review requested due to automatic review settings October 12, 2026 08:43

This comment was marked as outdated.

@rdettai-sk rdettai-sk changed the title Cooperative warm-up joins Fix retention to use secondary Oct 12, 2026
@rdettai-sk
rdettai-sk requested a review from Darkheir October 12, 2026 08:49
@rdettai-sk

Copy link
Copy Markdown
Collaborator Author

I admit it's a bit bloated, we can remove the dry run once this is rolled out.

@Darkheir

Copy link
Copy Markdown
Collaborator

I admit it's a bit bloated, we can remove the dry run once this is rolled out.

Most of the complexity comes from the dry run part :)

@rdettai-sk
rdettai-sk merged commit 5deaad6 into sekoia Oct 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants