Repository navigation
Fix backfilled secondary ts - #109
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new test must clean up its persistent PostgreSQL records.
1 open finding
What changed in this PR
Synchronizes returned split metadata with backfilled PostgreSQL secondary timestamp columns.
Changes:
- Restores secondary time ranges from database columns.
- Adds PostgreSQL regression coverage for backfilled splits.
| File | Description |
|---|---|
model.rs |
Hydrates secondary timestamp metadata. |
metastore.rs |
Tests column-only backfills. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Darkheir
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When deploying the secondarty timestamps we performed a backfill that only populated the secondary timstamp columns of pg but not the metadata. This would create a lot of warnings with the recent retention change. This PR auto fixes the metadta of these splits.
How was this PR tested?
Describe how you tested this PR.