Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Byte-rate accounting is inaccurate for streamed transfers, and multipart request coverage is incomplete.
Review effort: Balanced
Findings: 3
Open (3)
What changed in this PR
Adds temporary per-community S3 request, byte, and peak-rate metrics.
Changes:
- Extracts community UUIDs from object keys.
- Tracks per-community counters and rolling 30-second peaks.
- Instruments selected S3 operations.
| File | Description |
|---|---|
community_metrics.rs |
Implements extraction and metric aggregation. |
s3_compatible_storage.rs |
Records metrics for selected S3 operations. |
metrics_wrappers.rs |
Exposes action labels internally. |
lib.rs |
Registers the new module. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| None => {} | ||
| } | ||
| community_metrics::record_request(key, ActionLabel::UploadPart); | ||
| community_metrics::record_bytes(key, "upload", part.len()); |
Collaborator
Author
There was a problem hiding this comment.
I think this is OK for this PR
Darkheir
force-pushed
the
feat/temporary_per_community_object_storagemetrics
branch
from
October 2, 2026 14:08
9ce83be to
49df433
Compare
rdettai-sk
approved these changes
Oct 2, 2026
rdettai-sk
left a comment
rdettai-sk
left a comment
Collaborator
There was a problem hiding this comment.
We will need to be careful that this doesn't brake scrapping once deployad (+20k metrics)
Collaborator
Author
Do you have something specific in mind ? |
rdettai-sk
force-pushed
the
feat/temporary_per_community_object_storagemetrics
branch
from
October 8, 2026 15:19
49df433 to
1fb3531
Compare
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
rdettai-sk
force-pushed
the
feat/temporary_per_community_object_storagemetrics
branch
from
October 12, 2026 09:43
1fb3531 to
a616d21
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary: per-community object storage metrics
Adds object store request and byte counters labelled by community, taken from the object key.
Also adds a gauge for the peak 1-second rate over the last 30s, since the average rate over a 15–30s scrape hides the real max.
New metrics (
quickwit_storage_object_storage_community_*):requests_total,bytes_total,peak_requests_per_sec,peak_bytes_per_sec.PR has been created to modify as little things as possible and make its revert as painless as possible.