feat(config): support ${env.VAR_NAME} interpolation in config files - #263
Open
mwaldheim wants to merge 1 commit into
Open
feat(config): support ${env.VAR_NAME} interpolation in config files#263mwaldheim wants to merge 1 commit into
mwaldheim wants to merge 1 commit into
Conversation
Different provider plugins (GitHub, GitLab, etc.) each expect their
own token env var, which previously collided when multiple providers
were configured. Config values can now reference ${env.VAR_NAME},
expanded from the raw file content before format-specific parsing
(YAML/TOML/JSON), so each plugin's args can point at a distinct
environment variable.
Undefined variables produce a clear error naming every missing
variable, rather than silently substituting an empty string.
Fixes #243
Signed-off-by: mwaldheim <31657644+mwaldheim@users.noreply.github.com>
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #243
Config files couldn't reference environment variables, so plugin
argshad to hardcode secrets or rely on a single shared token env var — which collides when multiple provider plugins (e.g. GitHub + GitLab) are configured in the same pipeline.Fix
Any string value in the config can now reference
${env.VAR_NAME}, expanded from the raw file bytes before format-specific parsing (YAML/TOML/JSON) — so it works uniformly across all three formats:Undefined variables produce a clear error naming every missing variable, rather than silently substituting an empty string — a missing token is almost always a mistake, not an intentional empty value.
Testing
TestLoadConfig_EnvVarExpansionandTestLoadConfig_EnvVarExpansion_Undefinedgo test ./pkg/config/...passes.semrel.yaml.examplewith usage docs