Skip to content

Windows launcher: configure Claude-Data installs - #140

Merged
marcorottigni-s1 merged 1 commit into
Sentinel-One:mainfrom
pmoses-s1:fix/windows-launcher-claude-data
Oct 27, 2026
Merged

marcorottigni-s1 merged 1 commit into
Sentinel-One:mainfrom
pmoses-s1:fix/windows-launcher-claude-data

Conversation

@pmoses-s1

Copy link
Copy Markdown
Contributor

Summary

The Windows launcher's install command now configures Claude Desktop installs that keep their user data in %LOCALAPPDATA%\Claude-Data\<package id>\. On those installs the MCP servers did not appear, because the config was written only to %APPDATA%\Claude and the MSIX package copy. The image and MCP are unchanged at 1.5.7, and so is the plugin.

Changes

  • mcp/docker/s1-secops-mcp-launch.ps1
    • install writes each Claude Desktop config location that applies:
      • %APPDATA%\Claude
      • %LOCALAPPDATA%\Packages\Claude_*\LocalCache\Roaming\Claude
      • %LOCALAPPDATA%\Claude-Data\<package id>
    • Each config is merged with the user's existing settings and backed up before it is written.
    • Folders are listed one level at a time, so discovery works on Windows PowerShell 5.1.
    • install warns when no existing config is found, and explains how to target the correct file with -ConfigPath.
    • Output labels identify each location: the MSIX package copy or the Claude-Data per-account folder.
    • Unblock-File is skipped where the platform does not support it, so the launcher test suite also runs outside Windows.
  • mcp/docker/launcher-test.ps1: two new cases:
    • the Claude-Data config receives the servers and keeps its existing settings;
    • the warning appears when no config exists.
  • Docs:
    • plugins/s1-secops-skills/README.md (troubleshooting) and docs/installation.md describe the three Windows locations and the -ConfigPath fallback.
    • Changelog entries in CHANGELOG.md and mcp/s1-secops-mcp/CHANGELOG.md.

Verification

  • launcher-test.ps1: 18 passed, 0 failed on Windows PowerShell 5.1.26100.9711 (Windows 11) and on PowerShell 7.4.
  • Windows 11, Claude Desktop installed from the MSIX package:
    • install updated the %APPDATA% and MSIX configs, and correctly skipped an empty Claude-Data folder.
    • After a restart, s1-secops-mcp, purple-mcp and virustotal all show as running on image 1.5.7.
  • Repo checks: scrub guard passes, and 0 broken links across 273 markdown files.

@pmoses-s1
pmoses-s1 requested a review from a team as a code owner October 27, 2026 20:44

@roarinpenguin roarinpenguin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved to support windows users.

@marcorottigni-s1 marcorottigni-s1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to support Windows users.

@marcorottigni-s1
marcorottigni-s1 merged commit 8bbd541 into Sentinel-One:main Oct 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants