Fix #490: swap dead exchange rate API in !convert - #502
Open
prakhar2000 wants to merge 1 commit into
Open
prakhar2000 wants to merge 1 commit into
prakhar2000 wants to merge 1 commit into
Conversation
…erpolation Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #490
!convert is broken because exchangeratesapi.io now requires a key (and even then the free tier only allows EUR as the base). The issue calls it !currency but the command is !convert.
Changes in Parsers/Currency Converter.js:
{ base, rates }response the parser already reads!convert 10 usd to euractually hitsrates.EUR${fromCurrency}literallyI hit the Frankfurter endpoint and the response shape matches. Haven't run it on a live ServiceNow instance.
Not in this PR: decimal amounts (
(\d+)is also the activation regex) and checking HTTP status before JSON.parse.