feat: Show list of ignored gems - #2354
Merged
Merged
Conversation
written-fresh
force-pushed
the
feat/show-skipped-gems
branch
from
August 4, 2026 22:21
1ee1e56 to
6645633
Compare
written-fresh
marked this pull request as ready for review
August 4, 2026 22:24
KaanOzkan
reviewed
Aug 5, 2026
written-fresh
force-pushed
the
feat/show-skipped-gems
branch
2 times, most recently
from
August 5, 2026 15:25
28d3674 to
bcc671b
Compare
KaanOzkan
reviewed
Aug 18, 2026
KaanOzkan
left a comment
KaanOzkan
left a comment
Contributor
There was a problem hiding this comment.
Thank you, few more refactors. Also there might be some long lines, it'd be good to run rubocop before pushing.
written-fresh
force-pushed
the
feat/show-skipped-gems
branch
2 times, most recently
from
August 27, 2026 17:46
829bab8 to
0cd6cf5
Compare
written-fresh
force-pushed
the
feat/show-skipped-gems
branch
from
August 27, 2026 17:49
0cd6cf5 to
ff4e986
Compare
Skip explicitly excluded gems before resolving the requested gem list. This preserves `main` behavior and prevents `--include-dependencies` from generating dependencies of an excluded gem.
KaanOzkan
reviewed
Aug 28, 2026
| return @bundle.dependencies if gem_names.empty? | ||
|
|
||
| gem_names.each_with_object([]) do |gem_name, gems| | ||
| (gem_names - @exclude).each_with_object([]) do |gem_name, gems| |
Contributor
There was a problem hiding this comment.
CI revealed a failing case where a gem was supplied and excluded, brought back the original behaviour and added a test.
KaanOzkan
force-pushed
the
feat/show-skipped-gems
branch
from
August 28, 2026 14:19
7d799b4 to
85b6cca
Compare
KaanOzkan
approved these changes
Aug 28, 2026
KaanOzkan
enabled auto-merge
August 28, 2026 14:30
KaanOzkan
disabled auto-merge
August 28, 2026 14:30
KaanOzkan
enabled auto-merge
August 28, 2026 14:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses #1347 which aims to show a message when trying to run
tapioca gemon a ignored gem.Implementation
I have added a skipped gems property to the cli.
Tests
I have now written a test just to confirm something like
gem sorbetoutputs the warning that it was skipped. More than happy to add more if needed.No warning
Warning