[3.0] Theme split (wave 4, part 23) — give the two indexes one copy of the board list loop

[albertlast]

Description

BoardIndex.template.php and MessageIndex.template.php each carried their own copy of the loop that draws a list of boards — the one calling the template_bi_* helpers for the icon, info, stats, last post and children.

The two were identical. 32 lines apiece, and once leading whitespace is ignored the only difference is the array they walk:

$ diff -w bi_loop.txt mi_loop.txt
1c1
< 		foreach ($category['boards'] as $board) {
---
> 		foreach (Utils::$context['boards'] as $board) {

It becomes template_bi_board_list(), living beside the helpers it calls. MessageIndex::setupTemplate() already loads BoardIndex for those helpers, so there is nothing new to load. #9403 shared the helpers; this shares the loop that calls them.

Markup is untouched

The theme branch renames these classes on the way past — up_contain → board_container, info → board_info, lastpost → board_lastpost — and wraps the whole thing differently. That needs its index.css slice to come with it, so this keeps exactly what is on release-3.0 today and moves nothing but the loop.

Verification

Rendered output of the board index (#boardindex_table) and of the child board list on a board that has children (?board=1.0), captured before and after and compared as normalised HTML:

region	result
#boardindex_table	identical, 1639 chars
#board_1_childboards	identical, 647 chars

Whitespace is collapsed for that comparison, because the two copies indented their output differently and the shared one has to pick a single indentation. The DOM is the same; only the literal indentation inside the message index's copy shifts.

The template_bi_redirect_* branch is moved verbatim but not exercised — there is no redirect board on the test install.

Issues References (Fixes|Related|Closes)

Related: #9403, #7933