Skip to content

[3.0] Theme split (wave 4, part 33) — point the board index at design tokens - #9475

Merged
live627 merged 1 commit into
SimpleMachines:release-3.0from
albertlast:3.0/theme-boardindex-tokens
Aug 10, 2026
Merged

[3.0] Theme split (wave 4, part 33) — point the board index at design tokens#9475
live627 merged 1 commit into
SimpleMachines:release-3.0from
albertlast:3.0/theme-boardindex-tokens

Conversation

@albertlast

Copy link
Copy Markdown
Collaborator

Description

Part of the #7933 split.

The board index draws the same hairline in five places — around a board group, between the stats columns, above a child board list, above the info center bars, and above the message index information line. That is one line drawn five times, so it gets one --boardindex-border-* set rather than five that can drift apart. Also the board subject colour, the board picker lists and the info center's recent posts table. 15 tokens.

Every token holds the value the rule has today, so nothing renders differently.

Verification

Every rule in index.css parsed out of the file as text, applied to a probe, read back as a fixed list of 57 longhands:

965 rules, 55,005 computed values, 0 differences.

Issues References (Fixes|Related|Closes)

Related: #7933

The hairline the board index draws around a board group, between the
stats columns, above a child board list and above the message index
information line is one line drawn in five places, so it gets one set of
tokens. Also the board subject colour, the board picker lists and the
info center's recent posts table.

Every token holds the value the rule has today, so nothing renders
differently.

Signed-off-by: Mathias Albert <mathiaspapealbert@hotmail.com>
Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
@albertlast

Copy link
Copy Markdown
Collaborator Author

Re-ran the verification, because the first run was taken on ?topic=1.0 and that page is a fatal on release-3.0Object of type SMF\TimeInterval (inheriting DateInterval) has not been correctly initialized by calling parent::__construct(), which is #9405 and not merged yet. An error page still loads variables.css, and base and branch were captured in the same state, so the comparison held; but it is not a measurement anyone should have to take on trust.

Repeated on ?action=recent, which renders, with the capture now recording the page URL, whether #fatal_error is present, and the list of loaded stylesheets so a broken page cannot pass unnoticed:

OK  page=/index.php?action=recent fatal=False  965 rules, 55005 values, diffs 0

Same result. No change to the diff.

@albertlast albertlast mentioned this pull request Aug 9, 2026
@live627
live627 merged commit dfa0802 into SimpleMachines:release-3.0 Aug 10, 2026
4 checks passed
@jdarwood007 jdarwood007 added this to the 3.0 Alpha 5 milestone Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants