[3.0] Name the icons in the message icon picker - #9479
Merged
live627 merged 1 commit intoAug 10, 2026
Conversation
The XML for these has value and url attributes and carries the icon's name
as its text, so getAttribute('name') is null and every one of the 13 icons
in the picker announced itself as "null". Read the same text the title
already uses.
Signed-off-by: Mathias Papenbrock <mathiaspapealbert@hotmail.com>
Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clicking a post's message icon opens the icon picker, and every icon in it has
alt="null".IconList.onIconsReceived()readsicon.getAttribute('name'), but the XML that?action=xmlhttp;sa=messageiconsproduces has nonameattribute - the name is the element's text:getAttribute()returnsnull, and assigning that to.altstringifies it. Measured on a topic: 13 icons, 13 alts readingnull, whiletitle- which reads the text - is correct throughout. Inherited from 2.1, wherescript.jsbuilds the same markup the same way.How to test
Open a topic as someone who can modify a post, click the icon next to the subject, and inspect the picker. Before:
alt="null"on all of them. After:alt="Standard","Thumb Up","Lamp", … matching the titles.Issues References (Fixes|Related|Closes)
Found while sweeping the topic display for the #7933 split.