Repository navigation
test(zoom-client): rerun timer-core and club-card-sets on dev before release - #141
Merged
Merged
Conversation
…e release timer-core TC-01..08, 10, 11, 13 and club-card-sets CC-01..05, 09 passed in the real Zoom client on dev 3ce801a6. CC-06 ran only as a guest (401), CC-07/CC-08 and TC-09/TC-12 not run (human or unapproved KV edits).
ShuhaoZQGG
marked this pull request as ready for review
November 14, 2026 01:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release gate before merging
devintomaster.Why
npm run test:specs -- --stale --strictlistedtimer-coreandclub-card-setsas stale:LiveTab.jsx(#140) andCardImagesModal.jsx(57c4dde, the club-set label fix) changed after their last real run. CLAUDE.md asks for those to rerun before a release.What changes
Spec metadata only. No app code changes.
timer-core.md,club-card-sets.md:status: current,verified_at: 905d8d1, and a run note listing which steps ran.club-card-sets.mdCC-06: notes that a guest device with no Zoom session gets 401 before the role check.INDEX.md: both rows updated.Security
None.
Production impact
None. Docs and spec metadata only.
Testing
npm test: not rerun (no code change). CI passed on dev 905d8d1.npm run test:e2e: not rerun (no code change). CI passed on dev 905d8d1.npm run test:specs -- --stale --strict: 8 specs valid, none stale.Evidence (real Zoom client)
Run 2026-11-13 19:54–20:26 EST, Zoom 7.2.5 on macOS 26.7.2, dev version 3ce801a6 (tree of 905d8d1) with
FLAGS_FORCE"1",ENTITLEMENT_ENFORCE"1". Log:test-runs/2026-11-13-pre-master-specs/run.md(local).audience_size: 1on everytimer_started), TC-13 (import flags only Alex; suggestions, FINISH and the stage list all refuse him with "Pick a role for Alex on the Agenda tab first"). ⏭ TC-09, TC-12 (human).label: null; ver 12→13), CC-03 (web device downloads both images and shows CLUB BLUE), CC-04 (CLUB BLUE → Classic green → Classic yellow → CLUB RED on real video), CC-05, CC-09 (old image 404 after republish, ver 13→14).Not verified
timer-sounds(never run) is not covered by this PR.Look here first
e2e/zoom-client/INDEX.md: the two updated rows.