Repository navigation
feat(pro): one-time Pro launch announcement in the Zoom app - #144
Draft
ShuhaoZQGG wants to merge 3 commits into
Draft
ShuhaoZQGG wants to merge 3 commits into
ShuhaoZQGG wants to merge 3 commits into
Conversation
Once the pro flag is on, a free device gets a 'New: Pro for your club' window after a speech ends (PeriodicPrompts timing, shown once), handing off to the Upgrade dialog, and the footer's Upgrade button carries a red dot until any Upgrade dialog has been opened or 28 days after the window showed. Pro devices see neither. New zoom-client spec pro-launch.
…ce released A chime when the card changes, and music during breaks, listed only while the sounds flag is on, so nobody is sold a feature they would find locked.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pro is about to be switched on for the first time. In the last 30 days about 47 people used the Zoom app in production and about 7 the web timer, almost all of them inside Zoom during a meeting. So the announcement belongs in the Zoom app, at a moment that doesn't get in the way of timing.
What changes
proflag is on and the device is not Pro, and only once both answers have loaded.packages/shared/promptScheduler.js: newPRO_LAUNCH_PROMPT(one ask),DEFAULT_PROMPTS(whatselectDuePromptuses when no list is given, so the announcement is opt-in),isProLaunchBadgeDue.periodic_prompt_shown/answered/dismissedwithprompt: "pro_launch",pro_launch_learn_more, andupgrade_prompt_shownwithsource: "pro_launch"for the funnel.Security
None. Client-side UI and localStorage (
toastmaster_prompts) only.Production impact
Nothing shows while
prois off, which is the case in production today. Whenprois turned on, every free Zoom app user sees the window once after their next speech, and the footer dot. No migration. Old prompt history loads fine (a new record is added). Rollback is a revert, or turningprooff.Testing
npm test: 117 files, 2302 tests pass. New: scheduler (pro launch cadence, badge window, old stored data),PeriodicPrompts.test.jsx(gates: flag off, Pro device, plan or flags not loaded; once only; hand-off),Footer.test.jsx(dot),UpgradeModal.test.jsx(retires the announcement from every door). The gate tests fail when the gate is forced on.npm run test:e2e(CI=1): 48 pass, including the newe2e/zoom.pro-launch.spec.js(4).npm run test:specs -- --stale --strict: 9 specs valid, none stale.Evidence (real Zoom client)
Run 2026-11-13 21:24–21:29 EST, Zoom 7.2.5 on macOS 26.7.2, dev version c8774483 (this branch at eeaa840, built with
VITE_ENABLE_DEBUG_PANEL=true,FLAGS_FORCE"1"). New spece2e/zoom-client/pro-launch.md. Log:test-runs/2026-11-13-pro-launch/run.md(local).pro_launch_learn_more,upgrade_prompt_shown(source: pro_launch),periodic_prompt_answered(prompt: pro_launch).Not verified
Found while testing (not this change)
Club devices drop their club after a day without opening the app. The club token expires after 24 h and only the daily refresh renews it, and that refresh runs only when the last one is ≥24 h old. So the refresh sends an expired token, gets a 401, and the client treats it as revoked and leaves (
refreshClub→leaveClub). Seen live in this run:GET /api/club 401→POST /api/club/leave. It has been on master since 2026-09-27, so it doesn't block this PR, but it should be fixed before Pro has real clubs.Look here first
apps/zoom-app/src/components/PeriodicPrompts.jsx: theproLaunchEligiblegate and theenabledRef.packages/shared/promptScheduler.js:DEFAULT_PROMPTS, thePRO_LAUNCH_PROMPTrule,isProLaunchBadgeDue.apps/zoom-app/src/components/UpgradeModal.jsx:markPromptAnswered(PRO_LAUNCH_PROMPT)on open.