Skip to content

feat(pro): one-time Pro launch announcement in the Zoom app - #144

Draft
ShuhaoZQGG wants to merge 3 commits into
devfrom
feat/pro-launch-announcement
Draft

ShuhaoZQGG wants to merge 3 commits into
devfrom
feat/pro-launch-announcement

Conversation

@ShuhaoZQGG

Copy link
Copy Markdown
Contributor

Why

Pro is about to be switched on for the first time. In the last 30 days about 47 people used the Zoom app in production and about 7 the web timer, almost all of them inside Zoom during a meeting. So the announcement belongs in the Zoom app, at a moment that doesn't get in the way of timing.

What changes

  • A one-time "New: Pro for your club" window in the Zoom app, after a speech ends (the same timing as the club question and review ask: 2.5 s after FINISH, never while the timer runs). It lists what a club gets and says the timer stays free. "See what's in Pro" opens the existing Upgrade dialog; "Not now" or X closes it for good.
    • Shown only when the pro flag is on and the device is not Pro, and only once both answers have loaded.
    • It goes first when other prompts are also due, and the usual 3-day gap between prompts applies.
  • A red dot on the footer's Upgrade button (screen readers hear "New") until the user opens any Upgrade dialog, or 28 days after the window showed. Not shown to Pro devices.
  • Opening the Upgrade dialog from anywhere (footer, Sounds, Card Images, the announcement) retires both.
  • packages/shared/promptScheduler.js: new PRO_LAUNCH_PROMPT (one ask), DEFAULT_PROMPTS (what selectDuePrompt uses when no list is given, so the announcement is opt-in), isProLaunchBadgeDue.
  • The debug panel lists the new prompt.
  • The web timer is unchanged.
  • PostHog: periodic_prompt_shown/answered/dismissed with prompt: "pro_launch", pro_launch_learn_more, and upgrade_prompt_shown with source: "pro_launch" for the funnel.

Security

None. Client-side UI and localStorage (toastmaster_prompts) only.

Production impact

Nothing shows while pro is off, which is the case in production today. When pro is turned on, every free Zoom app user sees the window once after their next speech, and the footer dot. No migration. Old prompt history loads fine (a new record is added). Rollback is a revert, or turning pro off.

Testing

  • npm test: 117 files, 2302 tests pass. New: scheduler (pro launch cadence, badge window, old stored data), PeriodicPrompts.test.jsx (gates: flag off, Pro device, plan or flags not loaded; once only; hand-off), Footer.test.jsx (dot), UpgradeModal.test.jsx (retires the announcement from every door). The gate tests fail when the gate is forced on.
  • npm run test:e2e (CI=1): 48 pass, including the new e2e/zoom.pro-launch.spec.js (4).
  • npm run test:specs -- --stale --strict: 9 specs valid, none stale.

Evidence (real Zoom client)

Run 2026-11-13 21:24–21:29 EST, Zoom 7.2.5 on macOS 26.7.2, dev version c8774483 (this branch at eeaa840, built with VITE_ENABLE_DEBUG_PANEL=true, FLAGS_FORCE "1"). New spec e2e/zoom-client/pro-launch.md. Log: test-runs/2026-11-13-pro-launch/run.md (local).

  • ✅ PL-02: the window fits the Zoom panel; "See what's in Pro" opens the real Upgrade dialog; afterwards the debug panel reads "Pro launch: 0/1 asks, answered"; PostHog has pro_launch_learn_more, upgrade_prompt_shown (source: pro_launch), periodic_prompt_answered (prompt: pro_launch).
  • ✅ PL-03: on a Pro device, with the prompt due by cadence, FINISH brings nothing (still 0/1 asks after 6 s).
  • ⚠️ PL-01: Pro half only. The footer reads "Send Us Feedback · Review · Pro" on one line with no dot.
  • Footer width checked in Playwright at 400 px: the dot keeps the footer on one line (a "NEW" pill wrapped it, so it was replaced).

Not verified

  • PL-04 and PL-01's free half (the window appearing on its own after FINISH on a free device, and the dot) in the real client: the test Zoom account has its own Pro subscription. Covered by Playwright with the SDK mocked.
  • No link for club officers: there is no page about Pro on the website to link to yet. The window tells the timer to pass it on instead.

Found while testing (not this change)

Club devices drop their club after a day without opening the app. The club token expires after 24 h and only the daily refresh renews it, and that refresh runs only when the last one is ≥24 h old. So the refresh sends an expired token, gets a 401, and the client treats it as revoked and leaves (refreshClub → leaveClub). Seen live in this run: GET /api/club 401 → POST /api/club/leave. It has been on master since 2026-09-27, so it doesn't block this PR, but it should be fixed before Pro has real clubs.

Look here first

  • apps/zoom-app/src/components/PeriodicPrompts.jsx: the proLaunchEligible gate and the enabledRef.
  • packages/shared/promptScheduler.js: DEFAULT_PROMPTS, the PRO_LAUNCH_PROMPT rule, isProLaunchBadgeDue.
  • apps/zoom-app/src/components/UpgradeModal.jsx: markPromptAnswered(PRO_LAUNCH_PROMPT) on open.

Once the pro flag is on, a free device gets a 'New: Pro for your club'
window after a speech ends (PeriodicPrompts timing, shown once), handing off
to the Upgrade dialog, and the footer's Upgrade button carries a red dot
until any Upgrade dialog has been opened or 28 days after the window showed.
Pro devices see neither. New zoom-client spec pro-launch.
…ce released

A chime when the card changes, and music during breaks, listed only while the
sounds flag is on, so nobody is sold a feature they would find locked.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant