Repository navigation
[MS-1607] Make face capture acceptance thresholds remote-configurable - #1848
Open
meladRaouf wants to merge 1 commit into
Open
meladRaouf wants to merge 1 commit into
meladRaouf wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Non-finite values can block capture, and asynchronous initialization can process frames with stale defaults.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Makes face-capture acceptance thresholds remotely configurable while preserving existing defaults.
Changes:
- Adds validated yaw, roll, and face-area configuration.
- Applies thresholds across face SDKs.
- Adds parsing and ViewModel tests.
| File | Description |
|---|---|
ExperimentalProjectConfiguration.kt |
Defines and parses threshold configuration. |
ExperimentalProjectConfigurationTest.kt |
Tests defaults, clamping, and invalid ranges. |
LiveFeedbackViewModel.kt |
Applies configured thresholds during capture. |
LiveFeedbackViewModelTest.kt |
Verifies configured feedback behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
meladRaouf
force-pushed
the
feature/MS-1607-face-capture-thresholds-config
branch
from
October 8, 2026 11:24
1a405e3 to
0fdc93b
Compare
meladRaouf
requested review from
BurningAXE,
alex-vt,
alexandr-simprints and
luhmirin-s
October 9, 2026 10:03
meladRaouf
marked this pull request as ready for review
October 9, 2026 10:03
|
luhmirin-s
approved these changes
Oct 12, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





JIRA ticket
Will be released in: 2027.1.0
Notable changes
LiveFeedbackViewModel, so tuning them required an app release. They are now read from the project's custom (experimental) configuration, with a single set of values applied across all face SDKs:faceCaptureMaxYawDegreesfaceCaptureMaxRollDegreesfaceCaptureMinAreafaceCaptureMaxAreaTesting guidance
"faceCaptureMaxYawDegrees": 10in the project custom config, sync, and check that turning the head slightly now shows the "look straight" feedback."faceCaptureMaxArea": 0.35and check that "too close" triggers earlier; set"faceCaptureMinArea": 0.1and check that "too far" triggers later.Additional work checklist
🤖 Generated with Claude Code