Repository navigation
Move GetLightingConditionsAssessmentUseCase to infra:camera - #1854
Draft
meladRaouf wants to merge 1 commit into
Draft
meladRaouf wants to merge 1 commit into
meladRaouf wants to merge 1 commit into
Conversation
Move the lighting conditions assessment (use case, LightingConditionsAssessment and LightingConditionsAssessmentConfig) from feature:external-credential to infra:camera (com.simprints.infra.camera.lighting) so it can be reused by face capture. Behaviour is unchanged; the MFID-specific config mapping (GetLightingConditionsAssessmentConfigUseCase) stays in external-credential. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015LdiSju1eRbf6VoJ16Vqvo
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket
Will be released in: TBD
Notable changes
GetLightingConditionsAssessmentUseCase,LightingConditionsAssessmentandLightingConditionsAssessmentConfig(plus the use case's unit test) fromfeature:external-credentialtoinfra:camera(com.simprints.infra.camera.lighting), and made them public, so the lighting assessment can be reused by face capture as well as MFID.GetLightingConditionsAssessmentConfigUseCase(maps themfidLightingConditionsAssessment*experimental config keys) stays infeature:external-credential; the MFID screen and tests only have updated imports.feature:external-credentialandface:capturealready depend oninfra:camera.Testing guidance
./gradlew :infra:camera:testDebugUnitTest :feature:external-credential:testDebugUnitTestshould pass.mfidLightingConditionsAssessmentEnabled: truein the project's experimental config, MFID card scanning still shows the "too dim" / "too bright" hints as before.Additional work checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_015LdiSju1eRbf6VoJ16Vqvo