Skip to content

Move GetLightingConditionsAssessmentUseCase to infra:camera - #1854

Draft
meladRaouf wants to merge 1 commit into
mainfrom
feature/move-lighting-assessment-to-infra-camera
Draft

meladRaouf wants to merge 1 commit into
mainfrom
feature/move-lighting-assessment-to-infra-camera

Conversation

@meladRaouf

Copy link
Copy Markdown
Collaborator

JIRA ticket
Will be released in: TBD

Notable changes

  • Moved GetLightingConditionsAssessmentUseCase, LightingConditionsAssessment and LightingConditionsAssessmentConfig (plus the use case's unit test) from feature:external-credential to infra:camera (com.simprints.infra.camera.lighting), and made them public, so the lighting assessment can be reused by face capture as well as MFID.
  • Pure move, no behaviour change. The MFID-specific GetLightingConditionsAssessmentConfigUseCase (maps the mfidLightingConditionsAssessment* experimental config keys) stays in feature:external-credential; the MFID screen and tests only have updated imports.
  • No Gradle changes: both feature:external-credential and face:capture already depend on infra:camera.

Testing guidance

  • ./gradlew :infra:camera:testDebugUnitTest :feature:external-credential:testDebugUnitTest should pass.
  • Optional: with mfidLightingConditionsAssessmentEnabled: true in the project's experimental config, MFID card scanning still shows the "too dim" / "too bright" hints as before.

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

🤖 Generated with Claude Code

https://claude.ai/code/session_015LdiSju1eRbf6VoJ16Vqvo

Move the lighting conditions assessment (use case, LightingConditionsAssessment
and LightingConditionsAssessmentConfig) from feature:external-credential to
infra:camera (com.simprints.infra.camera.lighting) so it can be reused by
face capture. Behaviour is unchanged; the MFID-specific config mapping
(GetLightingConditionsAssessmentConfigUseCase) stays in external-credential.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015LdiSju1eRbf6VoJ16Vqvo
@cla-bot cla-bot Bot added the ... label Oct 12, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant