Skip to content

Remove protolite-well-known-types exclude from firebase-perf #1860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
meladRaouf wants to merge 1 commit into from
Closed

Remove protolite-well-known-types exclude from firebase-perf #1860

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions infra/logging/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,16 +36,7 @@ android {
dependencies {
implementation(libs.firebase.crashlytics)
api(libs.firebase.analytics)
implementation(libs.firebase.perf) {
/*
This exclude resolves a build failure (duplicate class/resource error)
caused by a conflict between 'com.google.firebase:protolite-well-known-types'
(a dependency of firebase-perf) and the 'com.google.protobuf:protobuf-javalite'
library. This forces Gradle to use the explicitly defined protobuf-javalite version.
Related issue: https://github.com/firebase/firebase-android-sdk/issues/5997/
*/
exclude(group = "com.google.firebase", module = "protolite-well-known-types")
}
implementation(libs.firebase.perf)
implementation(libs.kermit)
implementation(libs.androidX.core)
implementation(libs.kermit.io)
Expand Down
Loading