Switch sub-driver and main-driver to support SLGA migration by HunsupJung · Pull Request #2842 · SmartThingsCommunity/SmartThingsEdgeDrivers

HunsupJung · 2026-03-18T10:53:30Z

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

https://smartthings.atlassian.net/wiki/spaces/STHK/pages/5328012565/SLGA+migration+-+Test+Result

github-actions · 2026-03-18T10:54:00Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2026-03-18T10:54:45Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/akMXD55p7BMb

github-actions · 2026-03-18T10:55:50Z

Test Results

73 files 522 suites 0s ⏱️
3 026 tests 3 025 ✅ 0 💤 1 ❌
4 944 runs 4 943 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit bd6ecc6.

♻️ This comment has been updated with latest results.

github-actions · 2026-03-18T10:55:52Z

File	Coverage
All files	`90%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua	`90%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua	`89%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/unmigrated-matter-lock/init.lua	`92%`	✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against bd6ecc6

tpmanley · 2026-05-27T19:01:29Z

@@ -0,0 +1,758 @@
+-- Copyright 2025 SmartThings, Inc.


The unit test coverage of this file is currently only 24% so can you add more tests to get more coverage?

okay, I will improve the coverage.

hcarter-775

looks good!

hcarter-775 · 2026-05-14T18:19:08Z

+  local is_migrated = device:get_latest_state("main", capabilities.lockCodes.ID, capabilities.lockCodes.migrated.NAME) or nil
+    if device:supports_capability(capabilities.lockCodes) and is_migrated ~= true then


We should check if lockCodes is supported before checking the latest state.

Also, the capability cache could be flushed for some reason. I'd persist a field with this data instead of directly using the latest state.

Okay I will use LOCK_CODES_COPY_REQUIRED to use field

Hi Hunsup, sorry for the confusion here, I should have resolved this comment since you are now actually changing profiles for these devices (so lockCodes will not be supported any longer once the migraton is done).

Therefore, I think you should probably bring it back to how it was before!

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

…_handle.lua Co-authored-by: Harrison Carter <137556605+hcarter-775@users.noreply.github.com>

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

HunsupJung force-pushed the feature/slga-migration branch 3 times, most recently from eb1ad32 to 9bff284 Compare May 6, 2026 08:38

HunsupJung requested review from ctowns, hcarter-775, nickolas-deboom and tpmanley and removed request for ctowns, hcarter-775, nickolas-deboom and tpmanley May 6, 2026 08:46

HunsupJung force-pushed the feature/slga-migration branch 2 times, most recently from d6d06b2 to d0d0d76 Compare May 26, 2026 11:57

tpmanley reviewed May 27, 2026

View reviewed changes

HunsupJung force-pushed the feature/slga-migration branch 5 times, most recently from f3f97e2 to 4435fa3 Compare June 19, 2026 07:34

HunsupJung requested a review from tpmanley June 23, 2026 08:58

HunsupJung added the CGAI Contains code that was generated by AI label Jun 26, 2026

HunsupJung force-pushed the feature/slga-migration branch from 49f9112 to b9b8851 Compare June 26, 2026 07:07

hcarter-775 reviewed Jul 2, 2026

View reviewed changes

HunsupJung and others added 8 commits July 6, 2026 20:35

Switch sub-driver and main-driver to support SLGA migration

1a24d3c

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

Update test units

38b7b88

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

Modify typo and variable name

d8f651b

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

Change to reassign profile instead of updating existing one

75d271d

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

Update test unit and remove unnecessary test unit

6b67d95

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

Update drivers/SmartThings/matter-lock/src/unmigrated-matter-lock/can…

bf27f57

…_handle.lua Co-authored-by: Harrison Carter <137556605+hcarter-775@users.noreply.github.com>

Update drivers/SmartThings/matter-lock/src/unmigrated-matter-lock/can…

d3d5316

…_handle.lua Co-authored-by: Harrison Carter <137556605+hcarter-775@users.noreply.github.com>

Remove unncessary code

bd6ecc6

Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com>

HunsupJung force-pushed the feature/slga-migration branch from ee2aa47 to bd6ecc6 Compare July 6, 2026 11:42

HunsupJung requested a review from hcarter-775 July 6, 2026 11:43

		local is_migrated = device:get_latest_state("main", capabilities.lockCodes.ID, capabilities.lockCodes.migrated.NAME) or nil
		if device:supports_capability(capabilities.lockCodes) and is_migrated ~= true then

Uh oh!

Conversation

HunsupJung commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Mar 18, 2026

Uh oh!

github-actions Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tpmanley May 27, 2026

Choose a reason for hiding this comment

Uh oh!

HunsupJung May 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hcarter-775 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hcarter-775 May 14, 2026

Choose a reason for hiding this comment

Uh oh!

HunsupJung Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

hcarter-775 Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HunsupJung commented Mar 18, 2026 •

edited

Loading

github-actions Bot commented Mar 18, 2026 •

edited

Loading

github-actions Bot commented Mar 18, 2026 •

edited

Loading

github-actions Bot commented Mar 18, 2026 •

edited

Loading

hcarter-775 left a comment •

edited

Loading