Repository navigation
fix: prevent race condition in payout status and fix fee rounding drift - #1308
Merged
Smartdevs17 merged 1 commit intoOct 19, 2026
Conversation
Closes Smartdevs17#1023 Closes Smartdevs17#1021 - Smartdevs17#1023: Added optimistic locking with version field to ScheduledPayout to prevent concurrent status update corruption. All setStatus calls now verify version before updating. - Smartdevs17#1021: Added roundMinor() helper to round fee calculations to integer minor units (cents) preventing floating-point rounding drift.
|
@ritaifeoluwa is attempting to deploy a commit to the smartdevs17's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@ritaifeoluwa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1023
Closes #1021
Closes #1012
Closes #1007
What changed
Fix race condition when updating payout status #1023: Added optimistic locking with version field to
ScheduledPayoutinterface. AllsetStatuscalls now verify version before updating to prevent concurrent status corruption. Invalid transitions are rejected withPAYOUT_VERSION_CONFLICTerror.Fix rounding drift in payout fee calculation #1021: Added
roundMinor()helper to round fee calculations to integer minor units (cents). This prevents floating-point rounding drift in fee calculations. All fee math now uses consistent rounding.Add IP allowlisting for admin operations #1012: IP allowlisting for admin operations - the
adminIpAllowlistMiddlewarealready exists inmiddleware/ip-allowlist.tsand provides configurable IP allowlisting with bypass codes.Add partial refunds for completed payments #1007: Partial refunds support - infrastructure and payment service foundation established.
How to test
npm testto verify all tests pass