Skip to content

Fix inspect command packaging - #134

Closed
clholgat wants to merge 1 commit into
mainfrom
fix/cli-exclude-inspect-spec
Closed

Fix inspect command packaging#134
clholgat wants to merge 1 commit into
mainfrom
fix/cli-exclude-inspect-spec

Conversation

@clholgat

@clholgat clholgat commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • move the snapshot helper spec out of the runtime command source tree
  • clean the CLI dist directory before compilation to prevent stale command files
  • prevent published CLI builds from loading Jasmine specs as inspect commands

Verification

  • npm test: 91 specs, 0 failures
  • npm run build
  • verified dist/commands contains no spec or test JavaScript files
  • ran the rebuilt CLI against a live Android app: inspect status connected and inspect devices found com.snap.valdi.ayab_valdi_app

@github-actions github-actions Bot added the size/S label Aug 2, 2026
@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

📊 PR Size: size/S

Total changes: 11 lines (3 files)

Top files changed:

  • npm_modules/cli/scripts/clean-dist.js: +7 -0
  • npm_modules/cli/package.json: +1 -1
  • npm_modules/cli/test/commands/inspect_commands/snapshot.spec.ts: +1 -1

Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+)

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

🎉 Bazel & CI Test Results

Test Suite Result
API Surface Check ✅ success
macOS: C++ & Platform Tests ✅ success
Valdi Smoke Tests ✅ success
valdi_web Integration Test ✅ success
Snapshot Tests ✅ success
Linux: Build & Export ✅ success
Linux: C++ Tests ✅ success
Linux: Build Compiler ✅ success

All Bazel configuration and CI tests passed!

The build system and core tooling are working correctly.

🚀 Bazel remote cache is now enabled - future builds will be faster!

Workflow: Valdi CI

@beaucollins beaucollins left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Accepting.

Starting internal acceptance process.

@clholgat clholgat closed this Aug 4, 2026
clholgat added a commit that referenced this pull request Aug 5, 2026
GitOrigin-RevId: 15de439d75303935f25022f8166d0b4efeee2351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants