Repository navigation
fix: drop the spurious half-row padding in the filament submenu - #999
Merged
zhangzhend0ng merged 1 commit intoOct 13, 2026
Merged
Conversation
The submenu keeps half a row free for the scroll bar whenever the item count exceeds max_rows. That check read items.size(), but the popup holds the whole item vector and selects a group by filtering, so the value was always the total preset count — the reservation went in even for groups that never scroll, leaving a blank strip below the last row of the user, project and small vendor submenus. Test the rows the current group actually shows instead (count > max_rows), the same condition render_scroll_bar() uses to decide whether to draw a scroll bar. Groups that do scroll are unchanged.
zhangzhend0ng
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The half row reserved for the scroll bar in the second-level submenu was decided
by the total filament count (
items.size()) instead of the number of rows thecurrent group actually renders. There is only one submenu window and switching
groups filters rather than rebuilds it, so
items.size()is always the fullcount and always exceeds the submenu's row limit (8): the half row was added to
every submenu.
Fix: decide by the current group's row count (
count), consistent with thecondition that draws the scroll bar.
Size: 1 file, 1 line; no dependency, preset or configuration changes.
Screenshots/Recordings/Graphs
The bug before fixed
now the filament combobox show like this
Tests
Manual (GUI, on device): the extra blank space at the bottom of the second-level
submenu is gone, and the vendor groups under the system section behave normally.
No automated coverage: the repository's tests only cover pure logic, and popup
size computation is GUI layout.