You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
vendor's download plan re-walks the vendor loop's candidate selection, and the copy skips the vlt refusal and the ambiguous-variant check #1909
Both copies do the same work: the .socket/vendor/.uninstalled stand-in for a superseded install, representative_file + verify_file_patch + variant_matches_installed, variant-group resolution, the Bun refusal, linked_vendor_dir_refusal and the takeover gate. The plan's comments point at the loop instead of saying what they do ("The loop's installed-variant probe (see there)", "refuses it as ambiguous (see there)", L2801, L2829, L2856-L2857).
The copies have drifted:
The loop refuses vlt-routed packages (L3400-L3408). The plan only checks bun_refusal (L2861) and takes no vlt input. That contradicts the plan's own doc, "a package the loop refuses is never granted" (L3252-L3258). I have not executed this; vlt_lock::preflight_packages may hide it in practice.
The loop records vendor_variant_ambiguous (L3379). The plan silently drops an ambiguous candidate.
The plan matches through get_key_value, the loop through its own lookup.
On top of that, the .socket/vendor/.uninstalled path is built 4 times in production (L1936, L2802, L3151, L3302).
Proposed change
Extract one vendor_candidates(...) -> Vec<Candidate { purl, record, source, verdict }>, where the verdict is Vendor | Refuse{code, detail} | Ambiguous, from the loop's version.
plan_service_downloads maps the Vendor verdicts to PlannedDownload. The loop renders the refusals and runs the downloads.
Add a const UNINSTALLED_REL.
Size
vendor.rs only. About −90 / +40 lines.
Acceptance criteria
Vendor output and envelopes are unchanged on the vendored e2e suites.
New unit test: a vlt-refused candidate is not in the plan.
[agent] Triaged: priority:p1 (the plan's copy skips the vlt refusal, an npm-family package manager). Not a duplicate; no open PR touches plan_service_downloads. Related in spirit to #1908 but a different function and module, so not clustered.
[agent] Claiming this issue (shared root cause: vendor's download plan re-walks the loop's candidate selection, and its copy skips the vlt refusal and the ambiguous-variant check). Branch: agent/fix-vendor-plan-candidate-verdicts. Claim-ID: 2026-11-01T18:21:31Z-1da0a2
Activity
mikolalysenko commentedon Nov 1, 2026
[agent] Triaged: priority:p1 (the plan's copy skips the vlt refusal, an npm-family package manager). Not a duplicate; no open PR touches
plan_service_downloads. Related in spirit to #1908 but a different function and module, so not clustered.Generated by Claude Code
mikolalysenko commentedon Nov 1, 2026
[agent] Claiming this issue (shared root cause: vendor's download plan re-walks the loop's candidate selection, and its copy skips the vlt refusal and the ambiguous-variant check). Branch: agent/fix-vendor-plan-candidate-verdicts. Claim-ID: 2026-11-01T18:21:31Z-1da0a2
Generated by Claude Code
mikolalysenko commentedon Nov 1, 2026
[agent] Draft PR: #1947
Generated by Claude Code
Stop granting downloads vendor will refuse