Fix: Log Turnkey passkey cancellations as warnings - #2528
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, login cancellations initiated by users during a Turnkey passkey flow were being incorrectly logged as errors in Sentry, rather than warnings.
The root cause was an incomplete error handling check in
hooks/useUser.tsat line 434. The code only checked forerror?.name === 'NotAllowedError'to identify user cancellations. However, Turnkey-wrapped passkey cancellations present with a different error structure:error.error === 'UserCancelled'anderror.message === 'The user cancelled the request.'. This discrepancy caused these benign user actions to be captured as exceptions, cluttering error logs.This fix addresses the issue by replacing the narrow
error?.name === 'NotAllowedError'check with the more comprehensiveisPasskeyPromptError(error)utility. This utility, already imported and used in other parts of the codebase, correctly identifies various passkey prompt errors, including the specific Turnkey cancellation pattern.A regression test case has been added to
lib/utils/__tests__/passkey-credentials.test.tsto ensure the Turnkey cancellation error shape is correctly identified byisPasskeyPromptError.Fixes SOLID-10X
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.