Fix Sentry noise from cancelled queries during logout - #2529
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where
CancelledErrorfrom TanStack Query was being reported to Sentry as a legitimate error during user logout, leading to unnecessary noise.Root Cause:
During logout,
handleLogoutinuseUser.tscallsqueryClient.clear(), which cancels all pending TanStack queries. ThefetchIsDepositedquery, awaited inusePostSignupInit.ts, would then reject with aCancelledError. The catch block inusePostSignupInit.tswas unconditionally reporting all errors to Sentry, including these intentional cancellations.Fix:
Modified
hooks/usePostSignupInit.tsto importisCancelledErrorfrom@tanstack/react-queryand added a guard in thefetchIsDepositedcatch block. Now, if the caught error is anisCancelledError, it is silently ignored, preventing false Sentry reports.Verification:
npm install --legacy-peer-depsnpx expo lint --fix hooks/usePostSignupInit.ts(auto-fixed import sort, pre-existing react-compiler error remains)npx jest --testPathPattern="usePostSignupInit|useUser"(all tests passed)Fixes SOLID-WN
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.