Fix handleUnlock iOS passkey cancellation logging - #2530
Open
sentry[bot] wants to merge 1 commit into
Open
sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where
handleUnlockinapp/(protected)/(tabs)/settings/security.tsxwas incorrectly logging user cancellations of passkey prompts on iOS as errors to Sentry.The root cause was that the
isCancelledcheck (error instanceof Error && error.name === 'NotAllowedError') failed for errors originating from the iOS Turnkey SDK. On iOS, the SDK throws a plain object{error: 'UserCancelled', message: 'The user cancelled the request.'}rather than a standardErrorinstance, causing theinstanceof Errorcheck to returnfalse.To fix this, the faulty
isCancelledcheck has been replaced with the existingisWebAuthnUserCancelledErrorutility fromlib/execute.ts. This utility correctly identifies user cancellations across different platforms by inspecting the error message, thus preventing legitimate user cancellations from being reported as unexpected errors.Fixes SOLID-G9
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.