feat: Phase 2 DI, settings, secrets, package layout - #11
Merged
Conversation
Introduce create_app() with app.state DI (routes no longer use set_* globals), pydantic-settings SpectraXSettings, SecretsStore (file/keyring/memory) behind the credentials facade, and package moves into recording/, detection/, and api/. Add serve/doctor CLI entry points, deploy/systemd units, and tests for config/secrets/app factory. Phase 0 characterization and auth suites remain the regression net.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_app()+ DI: routers take deps fromapp.stateviaapi/deps.py; all routeset_*globals removedSpectraXSettingswith YAML +SPECTRAX_*env overrides;SurveillanceConfigadapter kept temporarilyrecording/,detection/,api/; shims at old import pathsserveanddoctor;configprints deprecation; no moreos._exitwatchdogdeploy/systemd/{spectrax,mediamtx}.service+ READMEStill open (follow-ups on this phase)
mediamtx.managed)run/detect; finish CLI collapseTest plan
spectrax doctorandspectrax servewith MediaMTX locally