Fix entities not spawning in structures on Forge - #4307
Merged
Conversation
Member
|
Ah I didn't notice that this was about API 8 when I suggested to open a PR. We usually no longer work with this outdated version but I guess I will make an exception this time because the changes are quite small. However we no longer merge API 8 changes upward, but this shouldn't be a problem in this case because the |
Yeregorix
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sponge replaces MinecraftServer#loadLevel with this world loading path, which never reaches MinecraftServer#prepareLevels.
Forge injects StructureSpawnManager.gatherEntitySpawns() at the very start of prepareLevels to populate its structure spawn registry (structuresWithSpawns, including the vanilla defaults pre-filled by the gather event).