Bound Step 4 substitution-table scan by heading, not a fixed byte window - #83
Merged
Merged
Conversation
check_docs.py read the table through a hardcoded 8000-byte window with only ~230 bytes of headroom against the current template. A row falling outside the window silently drops from `declared`, so CI reports a placeholder as missing a row even though the row exists — the wrong failure message pointing at the wrong problem. Scan to the next `### ` heading instead so the section boundary tracks the template's actual structure as it grows. Closes #80 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
Self-review rubric: Universal:
Repo-specific:
No judgment-call items to flag; all applicable items pass on direct evidence. |
dmccoystephenson
added a commit
that referenced
this pull request
Aug 3, 2026
…dow (#83) check_docs.py read the table through a hardcoded 8000-byte window with only ~230 bytes of headroom against the current template. A row falling outside the window silently drops from `declared`, so CI reports a placeholder as missing a row even though the row exists — the wrong failure message pointing at the wrong problem. Scan to the next `### ` heading instead so the section boundary tracks the template's actual structure as it grows. Closes #80 Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_docs.pyread the Step 4 substitution table through a hardcodedtable_start + 8000byte window, which had shrunk to ~231 bytes of headroom against the current template.declared, socheck_placeholdersreports a placeholder as "missing a Step 4 substitution-table row" even when the row exists — a misleading CI failure pointing contributors at the wrong problem.###heading instead of a byte count, so the section boundary tracks the template's actual structure as the table grows.Research grounding
No
RESEARCH.mdfinding applies — this is a mechanical CI-tooling correctness fix (byte-window vs. structural parsing), not a change tocreate-dev-loop.md's template or phase definitions.Test plan
python3 scripts/check_docs.pypasses cleanly on the current tree with the fix applied.declared(false "missing" report), and the new heading-bounded logic correctly finds it..claude/state staged (git status --porcelainbefore commit showed onlyscripts/check_docs.py).create-dev-loop.md/the template surface, so the/create-dev-loop-against-a-fixture validation inCLAUDE.md's "Testing changes" section doesn't apply here.Closes #80