Code quality review fixes - #196
Open
matteobachetti wants to merge 40 commits into
Open
Conversation
Baseline-correction (lc.baseline) calls stingray's _als, which still uses scipy.sparse.csc_matrix; scipy's dev builds now warn about it and our error::DeprecationWarning filter turns that into a test failure.
matplotlib 3.8 (pinned for oldestdeps) still calls pyparsing's pre-PEP8 enablePackrat(); pyparsing 3.3.0 turned that compat alias into a DeprecationWarning, which our filterwarnings turns into a collection error.
save_as_netcdf and read_from_netcdf never closed rootgrp on the exception paths, leaking an open HDF5 handle. When a later test wrote a new file at the same path, HDF5's file-open cache could key the new file to the stale handle and corrupt reads of it -- reproduced locally as the segfault seen in the alldeps CI job, in TestReadEvents.test_load_events. Using nc.Dataset as a context manager guarantees the close.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.