feat(API): refactor merge rpc - #17
Open
Sunny6889 wants to merge 22 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Delegate 17 more WalletSolidityApi read methods to the WalletApi singleton so each handler body lives once. 41/47 methods now delegate; the other 6 already share outer *Common helpers. Behavior notes: - getBlockByNum/getBlockByNum2: WalletApi adopts the guarded version, so the FullNode HEAD port now returns null for negative num. - getMerkleTreeVoucherInfo, isSpend, scanNoteByIvk/ByOvk, scanAndMarkNoteByIvk and the 3 shielded-TRC20 methods: solidity error paths now match WalletApi (return after onError; the two scanShieldedTRC20Notes* also add error logging). Client-observable behavior unchanged. - getAssetIssueByName: solidity debug log label Solidity -> FullNode. Still TODO: build verification and tests for the HEAD getBlockByNum guard change.
Sunny6889
changed the base branch from
feat/refactor_merge_http_servlets
to
develop
August 24, 2026 06:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details