fix: give the shader core count a field it fits in - #501
Open
Panchovix wants to merge 1 commit into
Open
Conversation
The GPU info bar reserves seven columns for the shader core count, of which the NSHC label already takes five, so the value is cut down to two characters. Even the placeholder does not survive it and the bar reads NSHC N/ instead of NSHC N/A. Eleven columns is what the two fields beside it use, and it leaves room for the counts the panfrost and radeon backends report.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GPU info bar reserves 7 columns for the shader core count, and the
NSHClabel already takes 5 of them. The value gets 2 columns, so even the placeholder does not fit:With 11 columns, the same width the two fields beside it use, it reads as intended and the three fields line up:
11 also leaves room for the counts the panfrost (
util_last_bit(shader)) and radeon (active CU count) backends actually report, which were being cut down as well.The row is 35 columns wide after the change and the device box is at least 64, so nothing else moves.
While looking at this I noticed
L2CFcan overflow its field too: panfrost setsl2cache_sizetol2_cache_features & (0xFF << 16), which can reach 8 digits against 6 columns of room. That looked like it might be a separate question about the value rather than the field, so I left it alone.