Repository navigation
fix(#39): normalise publisher email case to prevent duplicate accounts - #146
Merged
Busiii-adetiba merged 1 commit intoOct 20, 2026
Conversation
euniceamoni
commented
Oct 20, 2026
euniceamoni
commented
Contributor
- Trim and lowercase email in publisherRegisterSchema (Zod transform) so the HTTP layer normalises at the boundary before reaching the service.
- Same trim+lowercase applied in registerPublisher as defence-in-depth for callers that bypass the schema.
- Migration 0015_lowercase_publisher_email: detects collisions, aborts with an error listing conflicting addresses if any exist, then lowercases all existing rows in-place.
- New service-level tests cover uppercase, whitespace, combined, already- normalised inputs, and unique-constraint propagation.
- Two new route-level tests: schema normalises mixed-case input before calling the service; a case-variant duplicate returns 409 CONFLICT. closes Normalise publisher email case so duplicate accounts can't be created #39
…ate accounts - Trim and lowercase email in publisherRegisterSchema (Zod transform) so the HTTP layer normalises at the boundary before reaching the service. - Same trim+lowercase applied in registerPublisher as defence-in-depth for callers that bypass the schema. - Migration 0015_lowercase_publisher_email: detects collisions, aborts with an error listing conflicting addresses if any exist, then lowercases all existing rows in-place. - New service-level tests cover uppercase, whitespace, combined, already- normalised inputs, and unique-constraint propagation. - Two new route-level tests: schema normalises mixed-case input before calling the service; a case-variant duplicate returns 409 CONFLICT.
|
@euniceamoni Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@euniceamoni is attempting to deploy a commit to the work Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.