Repository navigation
feat: SSRF guard DNS resolution, webhook encryption, outbox worker, a… - #148
Merged
Busiii-adetiba merged 1 commit intoOct 20, 2026
Conversation
…dmin key config (SynapsVault#46 SynapsVault#47 SynapsVault#48 SynapsVault#49) SynapsVault#49 — ADMIN_API_KEY through config layer - Add ADMIN_API_KEY (optional) to envSchema in config.ts - adminAuth reads config.ADMIN_API_KEY instead of process.env - Log boot warning when key is unset; admin routes return 401 - Update admin.test.ts to mock config instead of process.env SynapsVault#47 — Encrypt webhook secrets at rest - Add WEBHOOK_ENCRYPTION_KEY (optional) to envSchema; boot warning when unset - Add encryptWebhookSecret / decryptWebhookSecret helpers (reuse AES-256-GCM) - publishers.ts encrypts secret before storing; decrypts before delivering/testing - webhookService.ts resolveTarget() decrypts secret on load - Migration 0016: idempotent marker (re-encryption happens at app layer) SynapsVault#46 — SSRF guard resolves DNS at delivery time - Add isPrivateIp() covering IPv4 private/loopback/link-local + IPv6 equivalents - Add resolveHostname() wrapping dns.promises.lookup - deliver() resolves hostname before each attempt; blocks on private IPs - Guards against DNS rebinding: re-resolves on every retry attempt - Update webhookService.test.ts: mock node:dns, add SSRF + rebinding tests SynapsVault#48 — Persistent webhook outbox - Add webhook_outbox table to schema + migration 0015 - Add enqueueWebhookEvent() — writes to outbox before delivery - Replace void emitToPublisher() with void enqueueWebhookEvent() in all callers - New webhookOutboxWorker.ts: polls pending rows, exponential backoff, marks delivered/failed, survives process restarts - Wire worker start/stop into index.ts with the other background workers - Add GET /publishers/me/webhooks/deliveries endpoint for delivery history .gitignore: add *.snap, *.tmp, *.bak, npm-debug.log*
|
@kurehkim334-lang is attempting to deploy a commit to the work Team on Vercel. A member of the Team first needs to authorize it. |
|
@kurehkim334-lang Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dmin key config (#46 #47 #48 #49)
#49 — ADMIN_API_KEY through config layer
#47 — Encrypt webhook secrets at rest
#46 — SSRF guard resolves DNS at delivery time
#48 — Persistent webhook outbox
.gitignore: add *.snap, *.tmp, .bak, npm-debug.log
close #46
close #47
close #48
close #49