Repository navigation
Fix file dialogs failing with PySide6 6.8/6.9 on Python 3.14 - #818
Open
cristianchiriac wants to merge 1 commit into
Open
cristianchiriac wants to merge 1 commit into
cristianchiriac wants to merge 1 commit into
Conversation
…y#815) QFileDialog.Options() without an argument raises 'EnumType.__call__() missing 1 required positional argument: value' there, so File > Open media file and the other Browse buttons did nothing. QFileDialog.Option(0) is the same empty set of options and works with PySide2 and all PySide6 versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #815.
With PySide6 6.8 or 6.9 on Python 3.14 (the combination Fedora 45 ships), calling
QtWidgets.QFileDialog.Options()with no argument raises:so File → Open media file and the other Browse buttons (player path, media directories, shared playlists, etc.) do nothing.
QFileDialog.Option(0)is the same empty set of options, so this replaces the 8 argument-lessOptions()calls with it. The calls that pass a flag (Options(QFileDialog.DontUseNativeDialog)and so on) already work everywhere and are unchanged.Testing: I created each value and passed it to
QFileDialog.setOptions()(offscreen platform):Options()Option(0)