Repository navigation
fix: reject non-positive placement indexes instead of wrapping to the last node - #100
Open
zekelinAlex wants to merge 1 commit into
Conversation
zekelinAlex
force-pushed
the
users/alexander.zekelin/applier-pp-security-role
branch
from
September 21, 2026 14:13
1690d79 to
dc57d1a
Compare
zekelinAlex
force-pushed
the
users/alexander.zekelin/placement-index-guard
branch
from
September 21, 2026 14:13
acf62a8 to
03b9005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports fix 4 of TALXIS/tools-devkit-templates#152 into the shared FormPlacementResolver. The old scripts selected $nodes[$index - 1], so an index of 0 became [-1] - PowerShell's last element - and silently patched a node the caller never asked for; the C# port inherited the same off-by-trust.
Now anything below 1 hits the regular not-found error, and the error texts state the indexes are 1-based, same wording as #152. One guard covers all seven resolver consumers (row, cell, control, column, section, dialog tab footer, control parameter).
Stacked on the security-role applier PR (#96).