Rewrite Method Member Syntax Elements Tests and Refactor Method Member Syntax Elements by alexanderlinne · Pull Request #465 · TNG/ArchUnitNET

alexanderlinne · 2026-06-12T13:05:18Z

Rewrite of the TypeSyntaxElementsTests similar to Add Tests For Object Predicates #393
Refactoring of the Type Syntax Elements similar to Refactor Object Syntax Elements #414

Note: there are still two implementations of HaveReturnType/NotHaveReturnType to keep the current differences in how System.Type and IType are handled.

Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>

codecov-commenter · 2026-06-12T13:07:02Z

Codecov Report

❌ Patch coverage is 94.53925% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.89%. Comparing base (312f823) to head (972b456).

Files with missing lines	Patch %	Lines
.../Members/MethodMembers/AddMethodMemberCondition.cs	78.57%	6 Missing ⚠️
.../Members/MethodMembers/AddMethodMemberPredicate.cs	78.57%	6 Missing ⚠️
.../MethodMembers/MethodMemberConditionsDefinition.cs	98.67%	0 Missing and 2 partials ⚠️
.../MethodMembers/MethodMemberPredicatesDefinition.cs	97.67%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   79.97%   82.89%   +2.91%     
==========================================
  Files         259      259              
  Lines       13326    12548     -778     
  Branches     1240     1194      -46     
==========================================
- Hits        10658    10402     -256     
+ Misses       2291     1785     -506     
+ Partials      377      361      -16

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mak638 · 2026-07-10T08:30:57Z

        public TNextElement HaveReturnType(IObjectProvider<IType> types) => CreateNextElement(MethodMemberConditionsDefinition.HaveReturnType(types));
-        public TNextElement HaveReturnType(Type type, params Type[] moreTypes) => CreateNextElement(MethodMemberConditionsDefinition.HaveReturnType(type, moreTypes));
+        public TNextElement HaveReturnType(IEnumerable<IType> types) => HaveReturnType(new ObjectProvider<IType>(types));
        public TNextElement HaveReturnType(IEnumerable<Type> types) => CreateNextElement(MethodMemberConditionsDefinition.HaveReturnType(types));


Was this an oversight or left out on purpose? Same for NotHaveReturnType(IEnumerable<Type> types) further below in this same file and for the corresponding method calls in AddMethodMemberPredicate.cs.

Suggested change

public TNextElement HaveReturnType(IEnumerable<Type> types) => CreateNextElement(MethodMemberConditionsDefinition.HaveReturnType(types));

public TNextElement HaveReturnType(IEnumerable<Type> types) => HaveReturnType(new SystemTypeObjectProvider<IType>(types));

I just realized that there are still two versions of HaveReturnType depending on the input arguments in MethodMemberConditionDefinition.cs but I'm still not exactly sure if this was on purpose and if so why. Let's have a chat about this the next time.

mak638 · 2026-07-10T09:07:08Z

+            should.NotHaveReturnType(helper.OtherRegularClassSystemType, helper.RegularClassSystemType).AssertOnlyViolations(helper);
+            should.NotHaveReturnType(new List<System.Type> { helper.OtherRegularClassSystemType, helper.RegularClassSystemType }).AssertOnlyViolations(helper);
+
+            // DoNotHaveReturnType predicate now uses consistent set-based semantics —


Praise: good catch of the error in the prior implementation. :)

mak638 · 2026-07-10T09:17:14Z

+
+Query: Method members that are "System.Void MethodDependencyNamespace.MethodDependencyClass::CalledMethod()" should be called by one of no types (impossible)
+Result: False
+Description: System.Void MethodDependencyNamespace.MethodDependencyClass::CalledMethod() is not called by 


Nitpick: The description is not ending correctly in this case. If it is easy to fix we should do so. If it isn't I guess it would still be okay since it is only an edge case.

mak638 · 2026-07-10T09:22:55Z

+
+----- Conditions -----
+
+Query: Method members that are "TypeNamespace.GenericClass`1<TypeNamespace.RegularClass> TypeNamespace.ClassWithGenericReturnType::MethodReturningGenericClass()" should not have return type "TypeNamespace.GenericClass`1[[TypeNamespace.RegularClass, TypeAssembly, Version=1.0.0.0, Culture=neutral, PublicKeyToken=015f...


Nitpick: The description of the generic type is pretty verbose (including assembly name, version, culture, ...) and should be shortened if possible.

mak638 · 2026-07-10T09:27:01Z

+
+Query: Method members that are "TypeNamespace.GenericClass`1<TypeNamespace.RegularClass> TypeNamespace.ClassWithGenericReturnType::MethodReturningGenericClass()" should not have return type "TypeNamespace.GenericClass`1[[TypeNamespace.RegularClass, TypeAssembly, Version=1.0.0.0, Culture=neutral, PublicKeyToken=015f...
+Result: False
+Description: TypeNamespace.GenericClass`1<TypeNamespace.RegularClass> TypeNamespace.ClassWithGenericReturnType::MethodReturningGenericClass() has return type "TypeNamespace.GenericClass`1"


In contrast: Here the description is actually to short since it is missing the actual generic type - this leads to a rather confusing error message in the end...

mak638 · 2026-07-10T09:30:27Z

+Description: TypeNamespace.GenericClass`1<TypeNamespace.RegularClass> TypeNamespace.ClassWithGenericReturnType::MethodReturningGenericClass() has return type "TypeNamespace.GenericClass`1"
+Message: 
+"Method members that are "TypeNamespace.GenericClass`1<TypeNamespace.RegularClass> TypeNamespace.ClassWithGenericReturnType::MethodReturningGenericClass()" should have return type "TypeNamespace.GenericClass`1[[TypeNamespace.OtherRegularClass, TypeAssembly, Version=1.0.0.0, Culture=neutral, PublicKeyToken=015..." failed:
+	TypeNamespace.GenericClass`1<TypeNamespace.RegularClass> TypeNamespace.ClassWithGenericReturnType::MethodReturningGenericClass() has return type "TypeNamespace.GenericClass`1"


See comment in MethodMemberSyntaxElementsTests.DoNotHaveReturnTypeTest.verified.txt - here the error message is actually wrong now because of this.

mak638 · 2026-07-10T09:33:37Z

+Description: TypeNamespace.GenericClass`1<TypeNamespace.RegularClass> TypeNamespace.ClassWithGenericReturnType::MethodReturningGenericClass() has return type "TypeNamespace.GenericClass`1"
+Message: 
+"Method members that are "TypeNamespace.GenericClass`1<TypeNamespace.RegularClass> TypeNamespace.ClassWithGenericReturnType::MethodReturningGenericClass()" should have return type "TypeNamespace.GenericClass`1[[TypeNamespace.OtherRegularClass, TypeAssembly, Version=1.0.0.0, Culture=neutral, PublicKeyToken=015..." failed:
+	TypeNamespace.GenericClass`1<TypeNamespace.RegularClass> TypeNamespace.ClassWithGenericReturnType::MethodReturningGenericClass() has return type "TypeNamespace.GenericClass`1"


See comment in MethodMemberSyntaxElementsTests.DoNotHaveReturnTypeTest.verified.txt - here the error message is actually wrong now because of this.

alexanderlinne added 2 commits June 12, 2026 12:27

test: rewrite method member syntax elements tests

ecbe09f

Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>

refactor: deduplicate implementation of method member syntax elements

972b456

Signed-off-by: Alexander Linne <alexander.linne@tngtech.com>

mak638 reviewed Jul 10, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rewrite Method Member Syntax Elements Tests and Refactor Method Member Syntax Elements#465

Rewrite Method Member Syntax Elements Tests and Refactor Method Member Syntax Elements#465
alexanderlinne wants to merge 2 commits into
mainfrom
method-member-syntax-elements-tests

alexanderlinne commented Jun 12, 2026

Uh oh!

codecov-commenter commented Jun 12, 2026

Uh oh!

mak638 Jul 10, 2026 •

edited

Loading

Uh oh!

mak638 Jul 10, 2026

Uh oh!

mak638 Jul 10, 2026

Uh oh!

mak638 Jul 10, 2026

Uh oh!

mak638 Jul 10, 2026

Uh oh!

mak638 Jul 10, 2026

Uh oh!

mak638 Jul 10, 2026

Uh oh!

mak638 Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	public TNextElement HaveReturnType(IEnumerable<Type> types) => CreateNextElement(MethodMemberConditionsDefinition.HaveReturnType(types));
	public TNextElement HaveReturnType(IEnumerable<Type> types) => HaveReturnType(new SystemTypeObjectProvider<IType>(types));


		----- Conditions -----

		Query: Method members that are "TypeNamespace.GenericClass`1<TypeNamespace.RegularClass> TypeNamespace.ClassWithGenericReturnType::MethodReturningGenericClass()" should not have return type "TypeNamespace.GenericClass`1[[TypeNamespace.RegularClass, TypeAssembly, Version=1.0.0.0, Culture=neutral, PublicKeyToken=015f...

Uh oh!

Conversation

alexanderlinne commented Jun 12, 2026

Uh oh!

codecov-commenter commented Jun 12, 2026

Codecov Report

Uh oh!

mak638 Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mak638 Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

mak638 Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

mak638 Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

mak638 Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

mak638 Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

mak638 Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

mak638 Jul 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mak638 Jul 10, 2026 •

edited

Loading