fix: Refine iterator and async method body scanning#469
Open
Optano-Dev wants to merge 1 commit into
Open
Conversation
Instead of resolving the first newobj instruction, search all newobj instructions for the first type that actually declares a MoveNext method. This prevents picking up an unrelated compiler-generated object. Fixes TNG#280
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #469 +/- ##
==========================================
- Coverage 79.97% 79.95% -0.03%
==========================================
Files 259 259
Lines 13326 13339 +13
Branches 1240 1242 +2
==========================================
+ Hits 10658 10665 +7
- Misses 2291 2294 +3
- Partials 377 380 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of resolving the first newobj instruction, search all newobj instructions for the first type that actually declares a MoveNext method. This prevents picking up an unrelated compiler-generated object.
Fixes #280