Skip to content

fix(linux-editor): keep picked schemes and code colors consistent - #4109

Merged
datlechin merged 4 commits into
TableProApp:mainfrom
sedax90:fix/linux-style-scheme-applied
Nov 9, 2026
Merged

datlechin merged 4 commits into
TableProApp:mainfrom
sedax90:fix/linux-style-scheme-applied

Conversation

@sedax90

@sedax90 sedax90 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Apply each picked scheme exactly in the editor, source dialogs, values and assistant code blocks.
  • Add Follow System Style in Preferences. Untouched settings still follow the desktop; explicitly picking Adwaita now keeps it light.
  • Pair assistant text and background colors, color NULL and empty-value placeholders to match, and release scheme previews when Preferences closes.
  • Keep structure and write-review SQL on the desktop's Adwaita pair.

Screenshots

Adwaita-dark selected. Before images are from the original report.

Light desktop Dark desktop
Before Before, light Before, dark
After After, light After, dark
Preferences Preferences, light Preferences, dark

Test plan

  • Widget tests cover exact and automatic choices, live updates, code-block background pixels, value placeholders and preview cleanup.
  • Updated defaults_match_schema for the separate automatic default and editor_page_contains_the_font_and_style_scheme_rows for the new switch.
  • CI Fast checks passed: both Clippy feature modes, build, 8 Meson suites, 7 Secret Service tests and source tarball. App Docker tests: 8 passed.
  • All CI checks passed, including Flatpak and database/SSH integration tests.

@datlechin datlechin changed the title fix(linux-editor): draw the style scheme the user picked, not its light or dark twin fix(linux-editor): keep picked schemes and code colors consistent Nov 8, 2026
@datlechin
datlechin added this pull request to the merge queue Nov 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Nov 9, 2026
@datlechin
datlechin added this pull request to the merge queue Nov 9, 2026
@datlechin
datlechin merged commit 9916074 into TableProApp:main Nov 9, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants